Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the message displayed when a map isn’t in the nominations maplist #597

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

FlaminSarge
Copy link
Contributor

New English text is “Map ‘%s’ is not in the nominations pool.”

Split off from #588 due to the pending discussion on how i18n requests will work under the new setup.

@FlaminSarge
Copy link
Contributor Author

How was https://sm.alliedmods.net/translator set up? What complications arise from the new model that prevent its use?

@FlaminSarge
Copy link
Contributor Author

Either an I18N label for issues or use of the Github Projects feature might be appropriate for handling and tracking I18N requests.

New English text is “Map ‘%s’ is not in the nominations pool.”
@FlaminSarge
Copy link
Contributor Author

Rebased this PR.

@KyleSanderson
Copy link
Member

@psychonic @asherkin there's no technical reason for this to stall for 3+ years. Are you okay if we land this new translatable field?

@peace-maker peace-maker added the i18n translation phrases label Mar 30, 2023
@peace-maker peace-maker reopened this Mar 30, 2023
@KyleSanderson KyleSanderson merged commit 5ba9816 into alliedmodders:master Mar 30, 2023
StarterX4 pushed a commit to StarterX4/sourcemod that referenced this pull request Aug 2, 2023
New English text is “Map ‘%s’ is not in the nominations pool.”
@FlaminSarge FlaminSarge deleted the nominations branch October 22, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n translation phrases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants