Change the message displayed when a map isn’t in the nominations maplist#597
Merged
Merged
Conversation
Contributor
Author
|
How was https://sm.alliedmods.net/translator set up? What complications arise from the new model that prevent its use? |
Contributor
Author
|
Either an I18N label for issues or use of the Github Projects feature might be appropriate for handling and tracking I18N requests. |
New English text is “Map ‘%s’ is not in the nominations pool.”
Contributor
Author
|
Rebased this PR. |
Member
|
@psychonic @asherkin there's no technical reason for this to stall for 3+ years. Are you okay if we land this new translatable field? |
peace-maker
approved these changes
Mar 30, 2023
StarterX4
pushed a commit
to StarterX4/sourcemod
that referenced
this pull request
Aug 2, 2023
New English text is “Map ‘%s’ is not in the nominations pool.”
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New English text is “Map ‘%s’ is not in the nominations pool.”
Split off from #588 due to the pending discussion on how i18n requests will work under the new setup.