-
-
Notifications
You must be signed in to change notification settings - Fork 461
Added more translation to basechat #674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added more translation to basechat #674
Conversation
Also fixed colors, because it didn't work without `\x01` at begin of string.
|
\x01 doesn't fix csgo colors. You need a space before \x01. Take a look at this. |
|
Do other prints from SourceMod base plugins have this extra space? I would think that it should only be added for CS:GO, if at all since it will cause these specific messages to be offset from the rest of chat. |
|
I think now it won't affect on non-csgo games. |
|
Has this fix been pushed yet? I am still seeing this issue on CS:GO servers. Seems like a fair fix that wont affect other games and would fix it until a better fix comes out. |
I haven't looked though the entire commit history, but judging by the PR still being "Open", no, I would assume that it hasn't been. |
|
I do apologize I did not check the status... Would this be possibly pushed soon? Just wondering if it would be or if there is a fix yet. |
|
Tested on both games, tf2 and cs:go, all works fine. Ready to merge. |
|
@TiBarification did you test that the coloring works on CS:GO? I don't think that the 0xB trick has worked for a couple of years. As @Bara noted, a space is commonly used now instead. |
|
@psychonic he added a space like here: https://github.com/alliedmodders/sourcemod/pull/674/files#diff-d6b22c2d8f239d0172a347a30daf28bcR404 ? |
Yes, it works fine.
Maybe it is really minor |
|
Wow, I totally missed that, only still seeing the 0B (which isn't needed or doing anything, but barely harming anything). Good catch. Thanks. |
Also fixed colors, because it didn't work without
\x01at begin of string.