Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more translation to basechat #674

Merged
merged 6 commits into from Dec 30, 2017

Conversation

@TiBarification
Copy link
Contributor

TiBarification commented Aug 26, 2017

Also fixed colors, because it didn't work without \x01 at begin of string.

Also fixed colors, because it didn't work without `\x01` at begin of string.
@TiBarification TiBarification changed the title Added translation more to basechat Added more translation to basechat Aug 26, 2017
@Bara

This comment has been minimized.

Copy link
Contributor

Bara commented Aug 26, 2017

\x01 doesn't fix csgo colors. You need a space before \x01. Take a look at this.

@psychonic

This comment has been minimized.

Copy link
Member

psychonic commented Aug 27, 2017

Do other prints from SourceMod base plugins have this extra space? I would think that it should only be added for CS:GO, if at all since it will cause these specific messages to be offset from the rest of chat.

@TiBarification

This comment has been minimized.

Copy link
Contributor Author

TiBarification commented Aug 27, 2017

I think now it won't affect on non-csgo games.

@omar-damaj

This comment has been minimized.

Copy link

omar-damaj commented Nov 6, 2017

Has this fix been pushed yet? I am still seeing this issue on CS:GO servers. Seems like a fair fix that wont affect other games and would fix it until a better fix comes out.

@psychonic

This comment has been minimized.

Copy link
Member

psychonic commented Nov 6, 2017

Has this fix been pushed yet?

I haven't looked though the entire commit history, but judging by the PR still being "Open", no, I would assume that it hasn't been.

@omar-damaj

This comment has been minimized.

Copy link

omar-damaj commented Nov 6, 2017

I do apologize I did not check the status... Would this be possibly pushed soon? Just wondering if it would be or if there is a fix yet.

@TiBarification

This comment has been minimized.

Copy link
Contributor Author

TiBarification commented Nov 6, 2017

Tested on both games, tf2 and cs:go, all works fine. Ready to merge.

@KyleSanderson KyleSanderson merged commit 6b257de into alliedmodders:master Dec 30, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@psychonic

This comment has been minimized.

Copy link
Member

psychonic commented Dec 31, 2017

@TiBarification did you test that the coloring works on CS:GO? I don't think that the 0xB trick has worked for a couple of years.

As @Bara noted, a space is commonly used now instead.

@Bara

This comment has been minimized.

@TiBarification

This comment has been minimized.

Copy link
Contributor Author

TiBarification commented Dec 31, 2017

@TiBarification did you test that the coloring works on CS:GO?

Yes, it works fine.

I don't think that the 0xB trick has worked for a couple of years.

Maybe it is really minor symbol/color code. I was guided by wiki.

@psychonic

This comment has been minimized.

Copy link
Member

psychonic commented Dec 31, 2017

Wow, I totally missed that, only still seeing the 0B (which isn't needed or doing anything, but barely harming anything). Good catch. Thanks.

@TiBarification TiBarification deleted the TiBarification:phrases_fix branch Jan 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.