Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Exception reported: Client 12 is not in game" #723

Merged
merged 3 commits into from Jul 12, 2018

Conversation

@komashchenko
Copy link
Contributor

komashchenko commented Nov 19, 2017

L 11/19/2017 - 16:37:02: [SM] Exception reported: Client 12 is not in game
L 11/19/2017 - 16:37:02: [SM] Blaming: adminhelp.smx
L 11/19/2017 - 16:37:02: [SM] Call stack trace:
L 11/19/2017 - 16:37:02: [SM] [0] PrintToConsole
L 11/19/2017 - 16:37:02: [SM] [1] Line 105, /home/builds/sourcemod/linux-1.9/build/plugins/adminhelp.sp::HelpCmd

@@ -58,6 +58,8 @@ public void OnPluginStart()

public Action HelpCmd(int client, int args)
{
if(!IsClientInGame(client)) return Plugin_Handled;

This comment has been minimized.

Copy link
@WildCard65

WildCard65 Nov 19, 2017

Contributor

Nit pick: Please make the style match the rest of the file, see line 78-81(after additions).

This comment has been minimized.

Copy link
@KyleSanderson

KyleSanderson Nov 21, 2017

Member

This is so close to being right, but breaks console support and moves the error (reliably) there as rcon/console is 0.

@@ -58,6 +58,8 @@ public void OnPluginStart()

public Action HelpCmd(int client, int args)
{
if(!IsClientInGame(client)) return Plugin_Handled;

This comment has been minimized.

Copy link
@KyleSanderson

KyleSanderson Nov 21, 2017

Member

This is so close to being right, but breaks console support and moves the error (reliably) there as rcon/console is 0.

Fix
@KyleSanderson KyleSanderson merged commit 52cdbb4 into alliedmodders:master Jul 12, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.