Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove goto from ExtensionSys.cpp #729

Merged
merged 2 commits into from May 25, 2018
Merged

Remove goto from ExtensionSys.cpp #729

merged 2 commits into from May 25, 2018

Conversation

@Drifter321
Copy link
Member

@Drifter321 Drifter321 commented Dec 1, 2017

Since I touched the function, i decided to also clean up the goto stuff.

Im not sure what

g_pSM->BuildPath(Path_SM, path, PLATFORM_MAX_PATH, "extensions/auto.%s/%s." PLATFORM_LIB_EXT, filename, bridge->gamesuffix);

is from (i have a vague remembrance of something with auto.) I assume it was how old engine specific extensions were loaded idk if we should still keep it or not.. but i left it.

Copy link
Member

@KyleSanderson KyleSanderson left a comment

Looks good to me.

/* COMPAT HACK: One-halfth, if ep2v, see if there is an engine specific build in the new place with old naming */
if (strcmp(bridge->gamesuffix, "2.tf2") == 0
|| strcmp(bridge->gamesuffix, "2.dods") == 0
|| strcmp(bridge->gamesuffix, "2.hl2dm") == 0
Copy link
Member

@KyleSanderson KyleSanderson Dec 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not your fault: I think I missed css here whenever this generalization stuff landed?

Copy link
Member Author

@Drifter321 Drifter321 Dec 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CS:S never was compat hacked. This was added after since CS:S for a long while was its own branch.

PLATFORM_MAX_PATH,
"extensions/%s." PLATFORM_LIB_EXT,
filename);
//Try further
Copy link
Member

@KyleSanderson KyleSanderson Dec 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent comment style.

{
g_pSM->BuildPath(Path_SM,
path,
PLATFORM_MAX_PATH,
"extensions/%s.2.ep2v." PLATFORM_LIB_EXT,
Copy link
Member

@KyleSanderson KyleSanderson Dec 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behaviour change, assuming this is a fix?

Copy link
Member Author

@Drifter321 Drifter321 Dec 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a behavior change, this is strictly for bintools. which previously used goto to the same buildpath.

@KyleSanderson KyleSanderson self-assigned this May 21, 2018
@Drifter321 Drifter321 merged commit e2767a3 into master May 25, 2018
2 checks passed
@asherkin
Copy link
Member

@asherkin asherkin commented Jun 3, 2018

@Drifter321 @KyleSanderson This change appears to have caused a crash loading certain extensions (PTAH, might be related to number of exts or loading an ext after another fails to load), https://crash.limetech.org/xmglmbqdoqnz, it has been bisected to this commit.

@Headline
Copy link
Member

@Headline Headline commented Jun 3, 2018

@asherkin's comment is relevant to #789

@asherkin
Copy link
Member

@asherkin asherkin commented Jun 3, 2018

This commit wasn’t in master at that point, might indeed be PTAH’s issue.

@Headline
Copy link
Member

@Headline Headline commented Jun 3, 2018

Oh, yeah you're right. These crashes looked identical, my bad.

@Headline Headline deleted the remove-goto-extsys branch Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants