-
-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent use of primitive float operation functions #763
Prevent use of primitive float operation functions #763
Conversation
I'd prefer "This native is internal implementation." rather than "This native only exists to be overloaded." Does adding |
I suppose deprecation is only correlated with removal, so I redact that. |
We want people to stop using these natives. They are not used internally in modern plugins, the JIT emits float opcodes directly, they're definitely on the removal path if we break binary compat for some reason. |
The deprecation warning doesn't carry through to the overloads, so 🚢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I look forward to the :steamsalty:
Apparently people use the float natives for actual float arithmetic; they're not really intended to be used directly. I've added a note to deter people from using these instead of their respective operators.