Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More amtl safe string fixes #785

Merged
merged 1 commit into from Mar 25, 2018
Merged

More amtl safe string fixes #785

merged 1 commit into from Mar 25, 2018

Conversation

@Headline
Copy link
Member

@Headline Headline commented Mar 19, 2018

Very similar to #784, but with more extension edits

@KyleSanderson KyleSanderson merged commit 5611ec5 into alliedmodders:master Mar 25, 2018
2 checks passed
@Headline Headline deleted the imbored branch Mar 25, 2018
@spumer
Copy link

@spumer spumer commented Mar 31, 2018

What improved by this PR? Why common snprintf was replaced?

@Headline
Copy link
Member Author

@Headline Headline commented Mar 31, 2018

There were some snprintfs where ke::SafeStrcpy should've been used. Also, for newer contributions we're favoring ke::SafeSprintf over snprintf. This was a quick sweeping change to keep things consistent across the project, but no issues were specifically fixed by this; just a code quality improvement.

@dvander
Copy link
Member

@dvander dvander commented Mar 31, 2018

snprintf null termination is super inconsistent across C vendors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants