Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More amtl safe string fixes #785

Merged
merged 1 commit into from
Mar 25, 2018
Merged

More amtl safe string fixes #785

merged 1 commit into from
Mar 25, 2018

Conversation

Headline
Copy link
Member

@Headline Headline commented Mar 19, 2018 •
edited
Loading

Very similar to #784, but with more extension edits

@KyleSanderson KyleSanderson merged commit 5611ec5 into alliedmodders:master Mar 25, 2018
@Headline Headline deleted the imbored branch March 25, 2018 20:01
@spumer
Copy link

spumer commented Mar 31, 2018

What improved by this PR? Why common snprintf was replaced?

@Headline
Copy link
Member Author

Headline commented Mar 31, 2018 •
edited
Loading

There were some snprintfs where ke::SafeStrcpy should've been used. Also, for newer contributions we're favoring ke::SafeSprintf over snprintf. This was a quick sweeping change to keep things consistent across the project, but no issues were specifically fixed by this; just a code quality improvement.

@dvander
Copy link
Member

dvander commented Mar 31, 2018

snprintf null termination is super inconsistent across C vendors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Headline @spumer @dvander @KyleSanderson