Send ShowActivity messages to TV clients #813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think I'd prefer that. |
|
Done. |
|
Sorry, I think what Asher meant was IsReplay or IsSTV, not the removal of all fake clients. |
asherkin
approved these changes
May 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShowActivityand related functions are used to inform all clients about the usage of admin commands (such as bans or mutes). These messages are not sent to any fake clients, however they should be sent to SourceTV/GOTV fake clients because messages they receive are actually visible to broadcast viewers and in demos recorded withtv_record.Player chat messages as well as SM functions like
PrintToChat/PrintToChatAllbroadcast to TV clients, butShowActivitydoes not.This fix could also be implemented by sending these messages to all fake clients, like
PrintToChatdoes.