Skip to content

Send ShowActivity messages to TV clients - #813

Merged
asherkin merged 2 commits into
alliedmodders:masterfrom
jason-e:fix-tv-client-missing-messages
May 9, 2018
Merged

Send ShowActivity messages to TV clients#813
asherkin merged 2 commits into
alliedmodders:masterfrom
jason-e:fix-tv-client-missing-messages

Conversation

@jason-e

@jason-e jason-e commented May 8, 2018

Copy link
Copy Markdown
Contributor

ShowActivity and related functions are used to inform all clients about the usage of admin commands (such as bans or mutes). These messages are not sent to any fake clients, however they should be sent to SourceTV/GOTV fake clients because messages they receive are actually visible to broadcast viewers and in demos recorded with tv_record.

Player chat messages as well as SM functions like PrintToChat/PrintToChatAll broadcast to TV clients, but ShowActivity does not.

This fix could also be implemented by sending these messages to all fake clients, like PrintToChat does.

@asherkin

asherkin commented May 8, 2018

Copy link
Copy Markdown
Member

This fix could also be implemented by sending these messages to all fake clients, like PrintToChat does.

I think I'd prefer that.

@jason-e

jason-e commented May 8, 2018

Copy link
Copy Markdown
Contributor Author

Done.

@KyleSanderson

Copy link
Copy Markdown
Member

Sorry, I think what Asher meant was IsReplay or IsSTV, not the removal of all fake clients.

@asherkin
asherkin merged commit 2904c87 into alliedmodders:master May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants