Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send ShowActivity messages to TV clients #813

Merged

Conversation

@jason-e
Copy link
Contributor

jason-e commented May 8, 2018

ShowActivity and related functions are used to inform all clients about the usage of admin commands (such as bans or mutes). These messages are not sent to any fake clients, however they should be sent to SourceTV/GOTV fake clients because messages they receive are actually visible to broadcast viewers and in demos recorded with tv_record.

Player chat messages as well as SM functions like PrintToChat/PrintToChatAll broadcast to TV clients, but ShowActivity does not.

This fix could also be implemented by sending these messages to all fake clients, like PrintToChat does.

@asherkin

This comment has been minimized.

Copy link
Member

asherkin commented May 8, 2018

This fix could also be implemented by sending these messages to all fake clients, like PrintToChat does.

I think I'd prefer that.

@jason-e

This comment has been minimized.

Copy link
Contributor Author

jason-e commented May 8, 2018

Done.

@KyleSanderson

This comment has been minimized.

Copy link
Member

KyleSanderson commented May 9, 2018

Sorry, I think what Asher meant was IsReplay or IsSTV, not the removal of all fake clients.

@asherkin asherkin merged commit 2904c87 into alliedmodders:master May 9, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.