Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate GetMaxClients #818

Merged
merged 1 commit into from May 23, 2018
Merged

Deprecate GetMaxClients #818

merged 1 commit into from May 23, 2018

Conversation

@rumblefrog
Copy link
Contributor

@rumblefrog rumblefrog commented May 23, 2018

馃帀

@@ -226,7 +226,7 @@ forward void OnClientPostAdminFilter(int client);
forward void OnClientPostAdminCheck(int client);

/**
* This function will be deprecated in a future release. Use the MaxClients variable instead.
* This function is deprecated. Use the MaxClients variable instead.
*
* Returns the maximum number of clients allowed on the server. This may
Copy link
Member

@Headline Headline May 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this whole paragraph explaining it's use, along with the @return. It's only comment should be about it's deprecation.

 /**
   * This function is deprecated. Use the MaxClients variable instead.
   */

Copy link
Member

@Headline Headline May 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Apparently we don't wipe documentation anywhere else, so feel free to ignore this review comment. Thanks!

Copy link
Contributor

@TF2CutContentWiki TF2CutContentWiki May 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-snip-

"dvander said " if someone gets the deprecation message, they might want to compare what it used to do with the new thing"

'nuff said. Changed my mind.

@TF2CutContentWiki
Copy link
Contributor

@TF2CutContentWiki TF2CutContentWiki commented May 23, 2018

Yay RumbleFrog

@asherkin asherkin merged commit 7f552e4 into alliedmodders:master May 23, 2018
2 checks passed
@asherkin
Copy link
Member

@asherkin asherkin commented May 23, 2018

Thanks! Congrats on your first PR to SM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants