Deprecate GetMaxClients #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Headline
requested changes
May 23, 2018
| @@ -226,7 +226,7 @@ forward void OnClientPostAdminFilter(int client); | |||
| forward void OnClientPostAdminCheck(int client); | |||
|
|
|||
| /** | |||
| * This function will be deprecated in a future release. Use the MaxClients variable instead. | |||
| * This function is deprecated. Use the MaxClients variable instead. | |||
| * | |||
| * Returns the maximum number of clients allowed on the server. This may | |||
There was a problem hiding this comment.
You can remove this whole paragraph explaining it's use, along with the @return. It's only comment should be about it's deprecation.
/**
* This function is deprecated. Use the MaxClients variable instead.
*/
There was a problem hiding this comment.
Note: Apparently we don't wipe documentation anywhere else, so feel free to ignore this review comment. Thanks!
Headline
approved these changes
May 23, 2018
|
Thanks! Congrats on your first PR to SM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉