Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark new methodmap natives as optional #867

Merged
merged 1 commit into from Aug 6, 2018

Conversation

@peace-maker
Copy link
Contributor

peace-maker commented Aug 6, 2018

The TopMenu methodmap natives weren't marked as optional if the extension was optional like the other normal natives.

The Regex natives weren't marked as optional at all before if the regex extension was included optionally.

This makes the error message cleaner in case topmenus aren't loaded and won't prevent plugins from loading if they're supposed to have an optional dependency.

adminmenu.smx (Admin Menu): Required extension "TopMenus" file("topmenus.ext") not running
basebans.smx (Basic Ban Commands): Native "TopMenu.Display" was not found
The `TopMenu` methodmap natives weren't marked as optional if the extension was optional like the other normal natives.

The `Regex` natives weren't marked as optional at all before if the regex extension was included optionally.

This makes the error message cleaner in case topmenus aren't loaded.
```
adminmenu.smx (Admin Menu): Required extension "TopMenus" file("topmenus.ext") not running
basebans.smx (Basic Ban Commands): Native "TopMenu.Display" was not found
```
@asherkin asherkin merged commit 7e3b1c3 into alliedmodders:master Aug 6, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@asherkin

This comment has been minimized.

Copy link
Member

asherkin commented Aug 6, 2018

Thanks!

@peace-maker peace-maker deleted the peace-maker:optional_methodmap branch Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.