Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `MAPLIST_FLAG_NO_DEFAULT` misuses #870

Merged
merged 2 commits into from Aug 19, 2018

Conversation

@asherkin
Copy link
Member

asherkin commented Aug 18, 2018

These two base plugins are using the MAPLIST_FLAG_NO_DEFAULT when they shouldn't, which causes much user (and SM developer) confusion as it is completely counter to the documentation.

Raised by @DoctorOcsid on Discord.

asherkin added 2 commits Aug 18, 2018
@asherkin asherkin added the Bug label Aug 18, 2018
@asherkin asherkin requested review from Drifter321 and Headline Aug 18, 2018
Copy link
Member

Headline left a comment

If my understanding is correct, the removal of that flag doesn't even change the behavior since sm_map menu points to default in the configurations correct?

@asherkin

This comment has been minimized.

Copy link
Member Author

asherkin commented Aug 19, 2018

These 2 currently have a separate file specified:

/* Admin menu, map menu */
"sm_map menu"
{
"file" "addons/sourcemod/configs/adminmenu_maplist.ini"
}
/* Admin menu, map voting menu */
"sm_votemap menu"
{
"file" "addons/sourcemod/configs/adminmenu_maplist.ini"
}

The problem is that upon removal of that configuration (or if that file can't be loaded), they fall back to loading all the maps rather than the documented behaviour of try "default" then "mapcyclefile".

There is indeed no out-of-the-box behaviour change from this PR though.

Copy link
Member

Headline left a comment

lgtm 🍻

@asherkin asherkin merged commit caf0914 into master Aug 19, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@asherkin asherkin deleted the asherkin-patch-1 branch Aug 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.