Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't double-format in ReplyToCommand. #932

Merged
merged 1 commit into from Dec 13, 2018

Conversation

@dvander
Copy link
Member

dvander commented Dec 13, 2018

Note: this was caught by triggering an assertion in the 1.9 exception handling code. We're not supposed to throw an error if the VM is already in an error state, and nothing cleared errors in between the two format operations.

@Fyren
Fyren approved these changes Dec 13, 2018
@KyleSanderson

This comment has been minimized.

Copy link
Member

KyleSanderson commented Dec 13, 2018

🤘

@dvander dvander merged commit 470486b into master Dec 13, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dvander dvander deleted the fix-neph-bug branch Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.