Added a method to get the value of whether an event's broadcasting di… #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This information is already included in the callback arguments - what are you doing that needs this info from the event handle? |
|
There is one problem: in another plugin, the notification for the event is disabled, but in another plugin, in the same event, it returns a different value when checked. |
asherkin
requested changes
Jan 3, 2019
core/smn_events.cpp
Outdated
| @@ -466,6 +483,7 @@ REGISTER_NATIVES(gameEventNatives) | |||
| {"Event.GetInt", sm_GetEventInt}, | |||
| {"Event.GetFloat", sm_GetEventFloat}, | |||
| {"Event.GetString", sm_GetEventString}, | |||
| {"Event.BroadcastDisabled.get", sm_GetEventBroadcast}, | |||
There was a problem hiding this comment.
Could you move this down under Event.BroadcastDisabled.set please. It's more readable to keep the properties together.
plugins/include/events.inc
Outdated
| * @return The boolean value of the whether an event's broadcasting disabled. | ||
| * @error Invalid Handle. | ||
| */ | ||
| native bool GetEventBroadcast(Handle event); |
There was a problem hiding this comment.
We're trying to avoid adding any more "legacy" API where possible, so could you remove this one and keep only the MethodMap property.
Headline
approved these changes
Jan 3, 2019
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sabled or not