Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent FrameIterator OOB Errors #949

Merged
merged 2 commits into from Jan 13, 2019

Conversation

@Headline
Copy link
Member

Headline commented Jan 13, 2019

Before this patch, we'd check OOB before incrementing which makes no sense. We'll increment always this time, and change our OOB check to account for that.

Prior versions of the FrameIterator never worked, so we should probably cherry-pick this to 1.9

Headline added 2 commits Jan 13, 2019
@Headline Headline requested a review from asherkin Jan 13, 2019
Copy link
Member

asherkin left a comment

This seems sane.

I thought about it quite a bit earlier, but there is no pattern where the existing could could have worked, is there? So this doesn't risk breaking anyone?

@Headline Headline merged commit b7e252d into master Jan 13, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Headline Headline deleted the frame-it-fix branch Jan 13, 2019
Headline added a commit that referenced this pull request Jan 13, 2019
@KyleSanderson

This comment has been minimized.

Copy link
Member

KyleSanderson commented Jan 23, 2019

This is a regression... You should not be able to slam Next until this overflows...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.