Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sm_cookies now display a number before the cookie (without arguments) similar to sm_help #977

Merged
merged 8 commits into from
Jul 9, 2020

Conversation

eyal282
Copy link
Contributor

@eyal282 eyal282 commented Apr 6, 2019

[001] cookieName - Cookie's description
[002] anotherCookieName - Another Cookie's description.

This is extremely effective when the description reaches a new line.

On top of that, I also made sm_cookies show the cookie's description rather than just the value in a manner similar to writing the name of a cvar.

THIS PULL REQUEST REQUIRES SOME DEGREE OF TESTING. I hope someone will have the spare time to test out everything possible and give some input on the change.

@eyal282 eyal282 changed the title It will now display a number before the cookie when using sm_cookies without arguments similar to sm_help sm_cookies now display a number before the cookie (without arguments) similar to sm_help Apr 6, 2019
Copy link
Member

@KyleSanderson KyleSanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, we have this pattern elsewhere. While an internal implementation detail this is a good addition. Thank you very much.

plugins/clientprefs.sp Outdated Show resolved Hide resolved
plugins/clientprefs.sp Outdated Show resolved Hide resolved
plugins/clientprefs.sp Outdated Show resolved Hide resolved
@eyal282
Copy link
Contributor Author

eyal282 commented Apr 9, 2019

I think I solved all issues, sorry for my lack of scripting skills when it comes to making it look sane, I come from AmxModX and learning a to format in a generally accepted way can be sometimes difficult to me.

@eyal282
Copy link
Contributor Author

eyal282 commented Apr 9, 2019

I should mention I have not a slight clue about anything related to the "Some checks haven't completed yet" of the "continuous-integration" error

@eyal282
Copy link
Contributor Author

eyal282 commented Apr 11, 2019

Anyways, are you okay with my changes or there is anything I forgot / new changes needed?

@eyal282
Copy link
Contributor Author

eyal282 commented Apr 12, 2019

Changed the while's formatting according to advice in sourcemod's discord channel.

int count = 1;

while
(ReadCookieIterator(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some how you keep making this look even worse...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give your own idea on how to fix how it looks?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while (... not while\n

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@Headline Headline self-requested a review April 12, 2019 19:35
Copy link
Member

@Headline Headline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dismissing the rest to peers

@Headline Headline added the Feature Request user requested feature label Apr 21, 2019
@KyleSanderson KyleSanderson merged commit 4a4b9ce into alliedmodders:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request user requested feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants