Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CS:GO CSWeaponDropBB signatures #985

Merged
merged 1 commit into from May 1, 2019

Conversation

Projects
None yet
6 participants
@Technoblazed
Copy link
Contributor

commented May 1, 2019

Fixes gamedata changes from the 4/30/19 CS:GO update. Found by rachnus in the sm discord.

Update cs:go CSWeaponDropBB signatures
Found by rachnus in the sm discord
@Headline
Copy link
Member

left a comment

Thanks!

@Headline Headline merged commit fc7453a into alliedmodders:master May 1, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Headline added a commit that referenced this pull request May 1, 2019

@TheExtr1m

This comment has been minimized.

Copy link

commented May 1, 2019

Hello. These signatures do not work, just updated on their SM server and does not work. Linux

@Fohdeesha

This comment has been minimized.

Copy link

commented May 1, 2019

Same issue as TheExtr1m, with these new signatures I'm still getting errors such as the below:

SM] Exception reported: Failed to lookup CSWeaponDropBB signature.

@Ayuto

This comment has been minimized.

Copy link

commented May 1, 2019

This PR actually hasn't changed the signatures at all (except removing the byte 56, but that is still a valid part of the signature. It's just not required to find a unique match). The first 6 bytes (2A) are just placeholders. SM's signature scanner ignores/skips them. I guess that has been done to still be able to find the signature even if the function has been hooked by a different server plugin.

It seems like the Windows signature is unchanged. The new Linux signature is:
\x2A\x2A\x2A\x2A\x2A\x2A\xEC\x70\x8B\x5D\x08\x0F\xB6\x75\x10

psychonic added a commit that referenced this pull request May 1, 2019

psychonic added a commit that referenced this pull request May 1, 2019

@psychonic

This comment has been minimized.

Copy link
Member

commented May 1, 2019

@Ayuto thanks. Fixing it up now.

Headline added a commit that referenced this pull request May 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.