Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shield and Bumpmine to cstrike.inc #991

Merged
merged 2 commits into from May 24, 2019
Merged

Conversation

@Bara
Copy link
Contributor

@Bara Bara commented May 1, 2019

Shield was added between P250 and Scar20 ( SteamDatabase/GameTracking-CSGO@eb493d0#diff-61078bd2bc26e33766f09f0c5b9ac935R22422 )

@psychonic psychonic requested a review from Drifter321 May 14, 2019
@qubka
Copy link

@qubka qubka commented May 24, 2019

May be better to do smth like that ? f5ad5af

Copy link
Member

@Drifter321 Drifter321 left a comment

Bumpmine is fine. Shield should not be added to the enum as it would break id's below it. The extension function GetWeaponIdFromDefIdx should be updated to have the respective SMCSWeapon_NONE be SMCSWeapon_SHIELD

Remove CSWeapon_SHIELD from CSWeaponID
@Bara
Copy link
Contributor Author

@Bara Bara commented May 24, 2019

👌🏻

@Headline Headline merged commit 9c55eed into alliedmodders:master May 24, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants