New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GetFrameIterator & FreeFrameIterator #140

Merged
merged 4 commits into from Sep 25, 2017

Conversation

Projects
None yet
4 participants
@Headline
Member

Headline commented Sep 17, 2017

In order to create RequestStackFrame in SourceMod, we need an
IFrameIterator from sp. This exposes a FrameIterator object for this
purpose.

Create GetFrameIterator & FreeFrameIterator
In order to create RequestStackFrame in SourceMod, we need an
IFrameIterator from sp. This exposes a FrameIterator object for this
purpose.
@dvander

This comment has been minimized.

Show comment
Hide comment
@dvander

dvander Sep 17, 2017

Member

FrameIterators must be used in a very specific way, which is why we didn't have this exposed already. I think as long as the comments are clear it should be okay though.

Member

dvander commented Sep 17, 2017

FrameIterators must be used in a very specific way, which is why we didn't have this exposed already. I think as long as the comments are clear it should be okay though.

Show outdated Hide outdated include/sp_vm_api.h Outdated
Show outdated Hide outdated include/sp_vm_api.h Outdated
Show outdated Hide outdated vm/base-context.cpp Outdated
Show outdated Hide outdated vm/base-context.cpp Outdated
@peace-maker

This comment has been minimized.

Show comment
Hide comment
@peace-maker

peace-maker Sep 17, 2017

Contributor

You should still bump the version define due to the IPluginContext change.

Contributor

peace-maker commented Sep 17, 2017

You should still bump the version define due to the IPluginContext change.

Headline added a commit to Headline/sourcemod that referenced this pull request Sep 17, 2017

BasePluginContext::DestroyFrameIterator(IFrameIterator *it)
{
delete static_cast<FrameIterator*>(it);
}

This comment has been minimized.

@KyleSanderson

KyleSanderson Sep 18, 2017

Member

nit: newline please

@KyleSanderson

KyleSanderson Sep 18, 2017

Member

nit: newline please

@dvander

This comment has been minimized.

Show comment
Hide comment
@dvander

dvander Sep 25, 2017

Member

Sorry for the delay - looks good!

Member

dvander commented Sep 25, 2017

Sorry for the delay - looks good!

@dvander dvander merged commit de7f703 into alliedmodders:master Sep 25, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment