-
Notifications
You must be signed in to change notification settings - Fork 70
Add #warning directive #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
compiler/sc2.cpp
Outdated
| "#endscript", "#error", "#file", "#if", "#include", "#line", "#pragma", | ||
| "#tryinclude", "#undef", | ||
| "#endscript", "#error", "#warning", "#file", "#if", "#include", | ||
| "#line", "#pragma", "#tryinclude", "#undef", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mystery tabs.
compiler/sc5-in.scp
Outdated
| /*238*/ "'%s:' is an illegal cast; use view_as<%s>(expression)\n", | ||
| /*239*/ "'%s' is an illegal tag; use %s as a type\n", | ||
| /*240*/ "'%s:' is an old-style tag operation; use view_as<%s>(expression) instead\n", | ||
| /*241*/ "user warning: %s\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use one of the unused ones?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see why not, is it generally preferred to use the lowest unused spot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya, preferred, but isn't super important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patching holes is definitely a nice to have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do. I’ll probably commit in the coming days
|
Alright. Let me know if there's anything else. |
<3 asherkin
Here's my test code along with compiler outputs. The first is how the current
#errordirective functions, and the second is the new#warningdirectiveFixes #169