Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align JIT HALT implementation with Interpreter and Verifier #175

Merged
merged 1 commit into from Feb 4, 2018
Merged

Conversation

@asherkin
Copy link
Member

@asherkin asherkin commented Feb 4, 2018

Next step is removing the code paths that can emit reachable halt's from spcomp (exit, sleep, and assert), but this fixes the crash for now.

For shell use it might be nice to have these work (and just map halt through to SetFailState for SM), but that is a discussion for the future.

Fixes #174

Next step is removing the code paths that can emit reachable `halt`'s from spcomp (exit, sleep, and assert), but this fixes the crash for now.
For shell use it might be nice to have these work (and just map `halt` through to `SetFailState` for SM), but that is a discussion for the future.

Fixes #174
@asherkin asherkin requested a review from dvander Feb 4, 2018
@dvander
Copy link
Member

@dvander dvander commented Feb 4, 2018

How was this emitting when the verifier rejects it?

@asherkin
Copy link
Member Author

@asherkin asherkin commented Feb 4, 2018

The SP version in SM 1.8-dev doesn't have #105.

@dvander
Copy link
Member

@dvander dvander commented Feb 4, 2018

Hah, okay.

@dvander dvander merged commit 3d52bf8 into master Feb 4, 2018
2 checks passed
@asherkin asherkin deleted the jit-halt branch Feb 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants