Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initialization of dynamic char[] #176

Merged
merged 1 commit into from Feb 6, 2018

Conversation

@peace-maker
Copy link
Contributor

peace-maker commented Feb 6, 2018

Initializing a string on the heap using

char[] str = "this is a value";
// NOT |char str[] = "this is a value";| which is on the stack

wasn't copying the correct string.

Add a test to catch this from now on.

Fixes alliedmodders/sourcemod#760

Initializing a string on the heap using
```
char[] str = "this is a value";
// NOT |char str[] = "this is a value";| which is on the stack
```
wasn't copying the correct string.

Add a test to catch this from now on.
@dvander

This comment has been minimized.

Copy link
Member

dvander commented Feb 6, 2018

Nice catch!

@dvander dvander merged commit 44c97f6 into alliedmodders:master Feb 6, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@peace-maker peace-maker deleted the peace-maker:dynstring_init branch Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.