Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initialization of dynamic char[] #176

Merged
merged 1 commit into from Feb 6, 2018

Conversation

@peace-maker
Copy link
Member

@peace-maker peace-maker commented Feb 6, 2018

Initializing a string on the heap using

char[] str = "this is a value";
// NOT |char str[] = "this is a value";| which is on the stack

wasn't copying the correct string.

Add a test to catch this from now on.

Fixes alliedmodders/sourcemod#760

Initializing a string on the heap using
```
char[] str = "this is a value";
// NOT |char str[] = "this is a value";| which is on the stack
```
wasn't copying the correct string.

Add a test to catch this from now on.
@dvander
Copy link
Member

@dvander dvander commented Feb 6, 2018

Nice catch!

@dvander dvander merged commit 44c97f6 into alliedmodders:master Feb 6, 2018
2 checks passed
@peace-maker peace-maker deleted the dynstring_init branch Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants