Fix register increment/decrement visit #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks good, nice catch - was there a test case that caused this, that we could add to the suite? |
Contributor
Author
|
Just found this while looking for code (writing bytecode reference). sc4.cpp saying that "inc/dec.alt" not generatable by original SP compiler. But it can be generated only by "emit" supported compiler or as direct smx modification. |
Member
|
Hrm, okay. With ungenerated opcodes I'd prefer to remove them from the verifier & VM. It makes the implementation surface a bit smaller. Lemme first make sure it didn't appear in older versions or anything though. |
Member
|
Well, it's never been used, but might as well keep it around. It's already implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably copy-paste mistake.