Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix register increment/decrement visit #190

Merged
merged 1 commit into from Mar 28, 2018

Conversation

@Kailo97
Copy link
Contributor

Kailo97 commented Mar 24, 2018

Probably copy-paste mistake.

@dvander

This comment has been minimized.

Copy link
Member

dvander commented Mar 26, 2018

Looks good, nice catch - was there a test case that caused this, that we could add to the suite?

@Kailo97

This comment has been minimized.

Copy link
Contributor Author

Kailo97 commented Mar 26, 2018

Just found this while looking for code (writing bytecode reference). sc4.cpp saying that "inc/dec.alt" not generatable by original SP compiler. But it can be generated only by "emit" supported compiler or as direct smx modification.

@dvander

This comment has been minimized.

Copy link
Member

dvander commented Mar 26, 2018

Hrm, okay. With ungenerated opcodes I'd prefer to remove them from the verifier & VM. It makes the implementation surface a bit smaller. Lemme first make sure it didn't appear in older versions or anything though.

@dvander

This comment has been minimized.

Copy link
Member

dvander commented Mar 28, 2018

Well, it's never been used, but might as well keep it around. It's already implemented.

@dvander dvander merged commit 4159e1a into alliedmodders:master Mar 28, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Kailo97 Kailo97 deleted the Kailo97:patch-1 branch Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.