Unify and simplify the test harness. #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test harness was too complicated. We had two versions, one for spcomp1 tests, and one for the shell. In addition they were invoked by a weird script generated by the build, based on templates, with separate templates for Windows and Mac/Linux. There's no need for any of this. The new harness is much simpler. It scans an objdir for spcomp/spshell binaries (since we could have dual-arch builds), scans for tests, and then runs a complete testing matrix. It now supports per-folder manifests as well. This setup will make it easier to add new configurations and even run tests in parallel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test harness was too complicated. We had two versions, one for spcomp1 tests, and one for the
shell. In addition they were invoked by a weird script generated by the build, based on templates,
with separate templates for Windows and Mac/Linux. There's no need for any of this.
The new harness is much simpler. It scans an objdir for spcomp/spshell binaries (since we could
have dual-arch builds), scans for tests, and then runs a complete testing matrix. It now supports
per-folder manifests as well.
This setup will make it easier to add new configurations and even run tests in parallel.