Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pow10 usage and shim. #208

Merged
merged 1 commit into from May 6, 2018

Conversation

@psychonic
Copy link
Member

psychonic commented May 6, 2018

Remove usage of pow10. This is documented as nonstandard GNU extension.

We already needed to have a shim for it on macOS, and using newer versions of Clang (tested v6) on Linux also fail to find it, even after explicitly including <math.h>. (I haven't tried newer GCC versions).

This is documented as nonstandard GNU extension. We already needed to have
a shim for it on macOS, and using newer versions of Clang (tested v6) on
Linux also fail to find it, even after explicitly including <math.h>.
(I haven't tried newer GCC versions).
@Amaroq7

This comment has been minimized.

Copy link
Contributor

Amaroq7 commented May 6, 2018

I'm also unable to build the compiler due that function. I've tried to compile using Clang 6. It seems it's been removed since the 2.27 glibc release.

* The libm functions pow10, pow10f and pow10l are no longer supported for
  new programs.  Programs should use the standard names exp10, exp10f and
  exp10l for these functions instead.

Source: https://lists.gnu.org/archive/html/info-gnu/2018-02/msg00000.html

Update:
GCC 8.1 seems to have no problems.

@dvander dvander merged commit 6d42be3 into master May 6, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dvander dvander deleted the byepow10 branch May 6, 2018
@Amaroq7 Amaroq7 mentioned this pull request Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.