Merged
Conversation
dvander
force-pushed
the
rm-lval-garbage
branch
2 times, most recently
from
1df9ff9 to
22b2340
Compare
dvander
force-pushed
the
rm-lval-garbage
branch
from
22b2340 to
1fd2255
Compare
dvander
force-pushed
the
sm-tests
branch
2 times, most recently
from
1f3ff45 to
338595b
Compare
dvander
force-pushed
the
rm-lval-garbage
branch
from
1fd2255 to
a833b96
Compare
Headline
approved these changes
Dec 2, 2018
Member
Headline
left a comment
Headline
left a comment
There was a problem hiding this comment.
c m p t a g
curiously
misapplied
practices
that
are
garbage
This doesn't exist in upstream Pawn. It's awkwardly attached to value structs even though it's actually parsing state. Even more strange is that sometimes it's a tag and sometimes it turns into a symbol count. It allowed an awkward feature to exist where enum members could be duplicated or shadowed across enum declarations. The compiler would then attempt to deduce the correct declaration when used as an index. Having shadowed constants in the global namespace is bizarre and we're better off not having this feature, or even trying to replicate it through saner parsing tricks. Now, if enum fields are shadowed, the compiler will error. The short-term fix for this is for developers to prefix their enum fields (which is common practice in core code).
dvander
force-pushed
the
rm-lval-garbage
branch
from
a833b96 to
c284725
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't exist in upstream Pawn. It's not clear what it does, or if it ever did anything, or if it worked correctly when it did. It's awkwardly attached to value structs even though it's actually parsing state. Even more strange is that sometimes it's a tag and sometimes it turns into a symbol count.