Merged
Conversation
lex() is pretty unreadable, it has duplicated code and weird state transitions, and it's too long. This patch breaks it up into separate methods that each perform a clear task. The operator lookup code is now inlined into a switch statement (similar to how the v2 lexer works), removing a loop+strcmp over a sizable chunk of the token table. Compiling SourceMod's plugins looks about 5% faster with this change. After this change, it will be much easier to implement a token map and remove the sc_token loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lex() is pretty unreadable, it has duplicated code and weird state transitions, and it's too long. This patch breaks it up into separate methods that each perform a clear task.
The operator lookup code is now inlined into a switch statement (similar to how the v2 lexer works), removing a loop+strcmp over a sizable chunk of the token table. Compiling SourceMod's plugins looks about 5% faster with this change.
After this change, it will be much easier to implement a token map and remove the sc_token loop.