Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the macro list with a hash table. #282

Merged
merged 1 commit into from Dec 2, 2018

Conversation

@dvander
Copy link
Member

dvander commented Dec 2, 2018

This removes the last use of stringpair and along with it more manual
memory management and C-era linked list code. There is no performance
difference because, amazingly, there was a tiny open-coded lookup cache
in the macro code. Go figure.

Copy link
Member

Headline left a comment

Sweet, awesome changes here.

only nit is the TRUE/FALSE in lexer.cpp but it’s a small nit

This removes the last use of stringpair and along with it more manual
memory management and C-era linked list code. There is no performance
difference because, amazingly, there was a tiny open-coded lookup cache
in the macro code. Go figure.
@dvander dvander force-pushed the rm-substable branch from 46ed028 to fe953b3 Dec 2, 2018
@dvander

This comment has been minimized.

Copy link
Member Author

dvander commented Dec 2, 2018

Heh, good catch. delete_subst was returning TRUE/FALSE which I preserved, but command() does not return boolean. I have no idea why it was doing this and it was probably incorrect. Fixed now.

@dvander dvander merged commit efa4070 into master Dec 2, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dvander dvander deleted the rm-substable branch Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.