Conversation
Headline
approved these changes
Dec 2, 2018
Member
Headline
left a comment
Headline
left a comment
There was a problem hiding this comment.
Sweet, awesome changes here.
only nit is the TRUE/FALSE in lexer.cpp but it’s a small nit
This removes the last use of stringpair and along with it more manual memory management and C-era linked list code. There is no performance difference because, amazingly, there was a tiny open-coded lookup cache in the macro code. Go figure.
Member
Author
|
Heh, good catch. delete_subst was returning TRUE/FALSE which I preserved, but command() does not return boolean. I have no idea why it was doing this and it was probably incorrect. Fixed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the last use of stringpair and along with it more manual
memory management and C-era linked list code. There is no performance
difference because, amazingly, there was a tiny open-coded lookup cache
in the macro code. Go figure.