Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when enabling profiler #316

Merged
merged 1 commit into from Feb 5, 2019

Conversation

@peace-maker
Copy link
Contributor

peace-maker commented Feb 4, 2019

When a plugin is currently executing code while the profiler is being activated, the VM tried to leave a profiling scope it never entered.

sm_rcon sm prof start vprof would crash the server.

https://crash.limetech.org/lgolraffyt46

vm/environment.h Outdated Show resolved Hide resolved
When a plugin is currently executing code while the profiler is being activated, the VM tried to leave a profiling scope it never entered.

`sm_rcon sm prof start vprof` would crash the server.
@peace-maker peace-maker force-pushed the peace-maker:profiling_scope_crash branch from fc08193 to 0675bac Feb 4, 2019
@dvander dvander merged commit 84de066 into alliedmodders:master Feb 5, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@peace-maker peace-maker deleted the peace-maker:profiling_scope_crash branch Feb 5, 2019
peace-maker added a commit to peace-maker/sourcepawn that referenced this pull request Jul 15, 2019
The crash fix in alliedmodders#316 didn't initialize the member variable, so it doesn't really fix the issue. It seems I just got tricked during testing with debug builds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.