Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when enabling profiler #316

Merged
merged 1 commit into from Feb 5, 2019

Conversation

peace-maker
Copy link
Member

When a plugin is currently executing code while the profiler is being activated, the VM tried to leave a profiling scope it never entered.

sm_rcon sm prof start vprof would crash the server.

https://crash.limetech.org/lgolraffyt46

vm/environment.h Outdated Show resolved Hide resolved
When a plugin is currently executing code while the profiler is being activated, the VM tried to leave a profiling scope it never entered.

`sm_rcon sm prof start vprof` would crash the server.
@dvander dvander merged commit 84de066 into alliedmodders:master Feb 5, 2019
@peace-maker peace-maker deleted the profiling_scope_crash branch February 5, 2019 08:01
peace-maker added a commit to peace-maker/sourcepawn that referenced this pull request Jul 15, 2019
The crash fix in alliedmodders#316 didn't initialize the member variable, so it doesn't really fix the issue. It seems I just got tricked during testing with debug builds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants