Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle spcomp. #340

Merged
merged 6 commits into from Jun 10, 2019

Conversation

@dvander
Copy link
Member

dvander commented Jun 8, 2019

This restyles include/.h and compiler/.{h,cpp} in AMTL style.

@dvander dvander force-pushed the restyle branch 3 times, most recently from cf0a274 to b14af28 Jun 8, 2019
ucell address PACKED; /* address in the code segment where generated code (for this file) starts */
char name[1]; /* ASCII string, zero-terminated */
ucell address
PACKED; /* address in the code segment where generated code (for this file) starts */

This comment has been minimized.

Copy link
@Fyren

Fyren Jun 8, 2019

Contributor

Ergh.

This comment has been minimized.

Copy link
@dvander

dvander Jun 8, 2019

Author Member

Thanks, will fix this.

{ 90, "zero.alt", sIN_CSEG, parm0 },
{ 89, "zero.pri", sIN_CSEG, parm0 },
{ 92, "zero.s", sIN_CSEG, parm1 },
/* node for "invalid instruction" */

This comment has been minimized.

Copy link
@Fyren

Fyren Jun 8, 2019

Contributor

This is probably better before.

This comment has been minimized.

Copy link
@dvander

dvander Jun 8, 2019

Author Member

Agree, I'll disable clang-format around this list.

@dvander dvander force-pushed the restyle branch from b14af28 to bf963ae Jun 8, 2019
int hier3(value *lval);
int hier2(value *lval);
int hier1(value *lval1);
int plnge(int *opstr, int opoff, HierFn hier, value *lval, const char *forcetag,

This comment has been minimized.

Copy link
@Fyren

Fyren Jun 8, 2019

Contributor

I'm not sure what the deal is, but it seems like where the asterisk gets nestled by the formatter varies. Here, it's with the variable name and in other places it's with the type.

Example in compiler/assember.h: void assemble(const char* outname, memfile_t* fin);

This comment has been minimized.

Copy link
@dvander

dvander Jun 8, 2019

Author Member

I think I have to forcefully disable this in the clang-format config.

@dvander dvander force-pushed the restyle branch from bf963ae to 5f54154 Jun 8, 2019
do { \
enum { assert_static__ = 1/(e) }; \
} while (0)
# define assert_static(e) \

This comment has been minimized.

Copy link
@Headline

Headline Jun 8, 2019

Member

didn’t know we had this, if we’re c++11 now we should trash this at some point. Unrelated to this pr, just a note

@dvander dvander force-pushed the restyle branch from 5f54154 to 31a1118 Jun 9, 2019
@dvander

This comment has been minimized.

Copy link
Member Author

dvander commented Jun 10, 2019

no more shrieks of horror, let's do this

@dvander dvander merged commit c44a169 into master Jun 10, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dvander dvander deleted the restyle branch Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.