Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning when non-stock functions are used by stock functions. #352

Merged
merged 1 commit into from
Aug 23, 2019

Conversation

dvander
Copy link
Member

@dvander dvander commented Aug 23, 2019

Bug: issue #349
Test: warnings/unused-from-member-function.sp

Bug: issue #349
Test: warnings/unused-from-member-function.sp
Copy link
Member

@Headline Headline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if a stock calls a non stock, should we not just error on that?

@dvander
Copy link
Member Author

dvander commented Aug 23, 2019

I think you're going that route, you might as well remove stock entirely. Its value is maximized when used sparingly, and that would encourage it to appear everywhere.

@dvander
Copy link
Member Author

dvander commented Aug 23, 2019

Note: this makes it behave more like "static inline" in C++.

@dvander dvander merged commit 79454d3 into master Aug 23, 2019
@dvander dvander deleted the bug349 branch August 23, 2019 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants