Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning when non-stock functions are used by stock functions. #352

Merged
merged 1 commit into from Aug 23, 2019

Conversation

@dvander
Copy link
Member

dvander commented Aug 23, 2019

Bug: issue #349
Test: warnings/unused-from-member-function.sp

Bug: issue #349
Test: warnings/unused-from-member-function.sp
Copy link
Member

Headline left a comment

if a stock calls a non stock, should we not just error on that?

@dvander

This comment has been minimized.

Copy link
Member Author

dvander commented Aug 23, 2019

I think you're going that route, you might as well remove stock entirely. Its value is maximized when used sparingly, and that would encourage it to appear everywhere.

@dvander

This comment has been minimized.

Copy link
Member Author

dvander commented Aug 23, 2019

Note: this makes it behave more like "static inline" in C++.

@dvander dvander merged commit 79454d3 into master Aug 23, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dvander dvander deleted the bug349 branch Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.