Fix warning when non-stock functions are used by stock functions. #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: issue #349 Test: warnings/unused-from-member-function.sp
Headline
reviewed
Aug 23, 2019
Member
Headline
left a comment
Headline
left a comment
There was a problem hiding this comment.
if a stock calls a non stock, should we not just error on that?
Member
Author
|
I think you're going that route, you might as well remove stock entirely. Its value is maximized when used sparingly, and that would encourage it to appear everywhere. |
Member
Author
|
Note: this makes it behave more like "static inline" in C++. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: issue #349
Test: warnings/unused-from-member-function.sp