Skip to content
Permalink
Branch: master
Commits on Nov 29, 2019
Commits on Nov 28, 2019
Commits on Nov 26, 2019
  1. Merge pull request #1613 from rahra/master

    allinurl committed Nov 26, 2019
    List of podcast related agents updated
Commits on Nov 22, 2019
  1. Updated code formatting.

    allinurl committed Nov 22, 2019
  2. Updated code formatting.

    allinurl committed Nov 22, 2019
Commits on Nov 16, 2019
  1. Merge pull request #1605 from cgzones/cc

    allinurl committed Nov 16, 2019
    misc improvements
Commits on Nov 15, 2019
  1. silence implicit conversions and overflows found by ubsan

    cgzones committed Nov 15, 2019
    src/parser.c:530:16: runtime error: implicit conversion from type 'int' of value 232 (32-bit, signed) to type 'char' changed the value to -24 (8-bit, signed)
    SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior src/parser.c:530:16 in
    
    src/parser.c:1620:19: runtime error: unsigned integer overflow: 1 - 10 cannot be represented in type 'unsigned int'
    SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior src/parser.c:1620:19 in
    
    src/parser.c:1606:17: runtime error: unsigned integer overflow: 1 - 10 cannot be represented in type 'unsigned int'
    SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior src/parser.c:1606:17 in
    
    src/settings.c:353:12: runtime error: implicit conversion from type 'int' of value -1 (32-bit, signed) to type 'size_t' (aka 'unsigned long') changed the value to 18446744073709551615 (64-bit, unsigned)
    SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior src/settings.c:353:12 in
    
    src/util.c:194:13: runtime error: unsigned integer overflow: 0 - 1 cannot be represented in type 'size_t' (aka 'unsigned long')
    SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior src/util.c:194:13 in
  2. configure: update formatting

    cgzones committed Nov 15, 2019
    * use recommend AS_HELP_STRING macro
    * check for invalid --enable-tcb and --enable-geoip values
    * drop duplicate adding -ltokyocabinet
  3. add FALLTHRU comments

    cgzones committed Nov 14, 2019
    In file included from src/websocket.c:56:0:
    src/websocket.c: In function ‘shutdown_ssl’:
    src/error.h:78:24: error: this statement may fall through [-Werror=implicit-fallthrough=]
     #define LOG(x) do { if (DEBUG_TEST) dbg_printf x; } while (0)
                            ^
    src/websocket.c:766:5: note: in expansion of macro ‘LOG’
         LOG (("SSL: SSL_shutdown, probably unrecoverable, forcing close.\n"));
         ^~~
    src/websocket.c:767:3: note: here
       case SSL_ERROR_ZERO_RETURN:
       ^~~~
    src/websocket.c: In function ‘send_ssl_buffer’:
    src/websocket.c:902:8: error: this statement may fall through [-Werror=implicit-fallthrough=]
         if ((bytes < 0 &&
            ^
    src/websocket.c:906:3: note: here
       case SSL_ERROR_ZERO_RETURN:
       ^~~~
    src/websocket.c: In function ‘accept_ssl’:
    src/websocket.c:803:8: error: this statement may fall through [-Werror=implicit-fallthrough=]
         if (ret < 0 && (errno == EAGAIN || errno == EWOULDBLOCK || errno == EINTR)) {
            ^
    src/websocket.c:809:3: note: here
       case SSL_ERROR_ZERO_RETURN:
       ^~~~
    src/websocket.c: In function ‘read_ssl_socket’:
    src/websocket.c:945:10: error: this statement may fall through [-Werror=implicit-fallthrough=]
           if ((bytes < 0 &&
              ^
    src/websocket.c:948:5: note: here
         case SSL_ERROR_ZERO_RETURN:
         ^~~~
  4. fix several -Wcast-qual warnings

    cgzones committed Nov 14, 2019
    src/json.c:609:40: warning: cast from 'const char *' to 'char *' drops const qualifier [-Wcast-qual]
        escape_json_output (json, (char *) conf.filenames[idx]);
                                           ^
    1 warning generated.
    
    src/output.c:215:30: warning: cast from 'const char *' to 'char *' drops const qualifier [-Wcast-qual]
      clean_output (fp, (char *) title);
                                 ^
    1 warning generated.
    
    src/sort.c:125:30: warning: cast from 'const void *' to 'char **' drops const qualifier [-Wcast-qual]
      return strcmp (*((char **) a), *((char **) b));
                                 ^
    src/sort.c:125:46: warning: cast from 'const void *' to 'char **' drops const qualifier [-Wcast-qual]
      return strcmp (*((char **) a), *((char **) b));
                                                 ^
    2 warnings generated.
    
    src/util.c:925:25: warning: cast from 'const char *' to 'unsigned char *' drops const qualifier [-Wcast-qual]
      p = (unsigned char *) src;
                            ^
    1 warning generated.
    
    src/websocket.c:260:25: warning: cast from 'const char *' to 'unsigned char *' drops const qualifier [-Wcast-qual]
      p = (unsigned char *) src;
                            ^
    src/websocket.c:1513:33: warning: cast from 'const char *' to 'unsigned char *' drops const qualifier [-Wcast-qual]
      SHA1Update (&sha, (uint8_t *) s, len);
                                    ^
    2 warnings generated.
  5. update compiler warnings in Makefile

    cgzones committed Nov 14, 2019
    * drop duplicate use of -Wextra, namely -W
    * drop -Wno-long-long, long long is used
    * drop -Wno-missing-field-initializers
    * add -Wshadow and -Wold-style-definition
  6. add format attribute to set_dbparam

    cgzones committed Nov 14, 2019
    src/tcbtdb.c:124:49: error: format string is not a string literal
          [-Werror,-Wformat-nonliteral]
      n = vsnprintf (params + len, DB_PARAMS - len, fmt, args);
                                                    ^~~
    1 error generated.
  7. make bin2c more cautious

    cgzones committed Nov 14, 2019
    * check fread for error
    * check if the complete file was read (EOF reached)
    * exit on writing null character, which would terminate the content prematurely
    * check for error after writing file
Commits on Nov 14, 2019
  1. set length to print for non nul-terminated char arrays

    cgzones committed Nov 14, 2019
    src/output.c: In function ‘output_html’:
    src/output.c:247:24: error: ‘%s’ directive argument is not a nul-terminated string [-Werror=format-overflow=]
      247 |   fprintf (fp, "<style>%s</style>", fa_css);
          |                        ^~           ~~~~~~
    In file included from src/output.c:59:
    src/facss.h:1:12: note: referenced argument declared here
        1 | const char fa_css[18458] = {
          |            ^~~~~~
    src/output.c:248:24: error: ‘%s’ directive argument is not a nul-terminated string [-Werror=format-overflow=]
      248 |   fprintf (fp, "<style>%s</style>", bootstrap_css);
          |                        ^~           ~~~~~~~~~~~~~
    In file included from src/output.c:58:
    src/bootstrapcss.h:1:12: note: referenced argument declared here
        1 | const char bootstrap_css[51608] = {
          |            ^~~~~~~~~~~~~
    src/output.c:249:24: error: ‘%s’ directive argument is not a nul-terminated string [-Werror=format-overflow=]
      249 |   fprintf (fp, "<style>%s</style>", app_css);
          |                        ^~           ~~~~~~~
    In file included from src/output.c:60:
    src/appcss.h:1:12: note: referenced argument declared here
        1 | const char app_css[16587] = {
          |            ^~~~~~~
    src/output.c:309:25: error: ‘%s’ directive argument is not a nul-terminated string [-Werror=format-overflow=]
      309 |   fprintf (fp, "<script>%s</script>", d3_js);
          |                         ^~            ~~~~~
    In file included from src/output.c:61:
    src/d3js.h:1:12: note: referenced argument declared here
        1 | const char d3_js[151139] = {
          |            ^~~~~
    src/output.c:310:25: error: ‘%s’ directive argument is not a nul-terminated string [-Werror=format-overflow=]
      310 |   fprintf (fp, "<script>%s</script>", hogan_js);
          |                         ^~            ~~~~~~~~
    In file included from src/output.c:62:
    src/hoganjs.h:1:12: note: referenced argument declared here
        1 | const char hogan_js[8554] = {
          |            ^~~~~~~~
    src/output.c:311:25: error: ‘%s’ directive argument is not a nul-terminated string [-Werror=format-overflow=]
      311 |   fprintf (fp, "<script>%s</script>", app_js);
          |                         ^~            ~~~~~~
    In file included from src/output.c:64:
    src/appjs.h:1:12: note: referenced argument declared here
        1 | const char app_js[39695] = {
          |            ^~~~~~
    src/output.c:312:25: error: ‘%s’ directive argument is not a nul-terminated string [-Werror=format-overflow=]
      312 |   fprintf (fp, "<script>%s</script>", charts_js);
          |                         ^~            ~~~~~~~~~
    In file included from src/output.c:63:
    src/chartsjs.h:1:12: note: referenced argument declared here
        1 | const char charts_js[20420] = {
          |            ^~~~~~~~~
  2. silence alignment warnings by intermediate void casting

    cgzones committed Nov 14, 2019
    src/sha1.c:66:11: warning: cast from 'uint8_t *' (aka 'unsigned char *') to 'CHAR64LONG16 *' increases required alignment from 1 to 4 [-Wcast-align]
      block = (CHAR64LONG16 *) buffer;
              ^~~~~~~~~~~~~~~~~~~~~~~
    1 warning generated.
    
    src/websocket.c:964:15: warning: cast from 'struct sockaddr *' to 'struct sockaddr_in *' increases required alignment from 2 to 4 [-Wcast-align]
        return &(((struct sockaddr_in *) sa)->sin_addr);
                  ^~~~~~~~~~~~~~~~~~~~~~~~~
    src/websocket.c:966:13: warning: cast from 'struct sockaddr *' to 'struct sockaddr_in6 *' increases required alignment from 2 to 4 [-Wcast-align]
      return &(((struct sockaddr_in6 *) sa)->sin6_addr);
                ^~~~~~~~~~~~~~~~~~~~~~~~~~
    2 warnings generated.
  3. Merge pull request #1601 from cgzones/travis

    allinurl committed Nov 14, 2019
    travis and configure updates
Commits on Nov 12, 2019
  1. configure.ac: run autoupdate

    cgzones committed Nov 12, 2019
  2. update travis configuration

    cgzones committed Nov 12, 2019
    * only clone with depth 3
    * add build configuration with GeoIP2 and openssl
    * drop restriction to master branch
    * install dependencies via the apt addon
    * compile in parallel
    * enable autoreconf warnings
Commits on Oct 30, 2019
  1. Merge pull request #1581 from benjaoming/readme-docker-and-log-updates

    allinurl committed Oct 30, 2019
    Added a troubleshooting section to README
Commits on Oct 29, 2019
  1. Merge pull request #1578 from rahra/master

    allinurl committed Oct 29, 2019
    added list with podcast-related agent strings
Older
You can’t perform that action at this time.