POSIX has made usleep(2) obsolete in favour of nanosleep(2) #1990
+20
−9
Conversation
usleep(2) also has no effect if equal to greater than 1000000 which happens to match HTML_REFERS, but no error was checked. This caused 100% CPU utiliation constantly following the tail of the web server access log with default value. nanosleep(2) has more relaxed limits. This commit does a like for like replacement and also adds error checking in case of a similar error in the future. Signed-off-by: Roy Marples <roy@marples.name>
|
Merged. Thanks very much for the heads up on this! |
|
Question, were you running goaccess from systemd? |
|
Well, as my prior pull request fixed the build for NetBSD that can safely be a no as systemd is Linux only. However, I did see the issue you were referring to and all I can say is fix this is highly dependant on libc. |
|
Got it. Thanks for the info! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
usleep(2) also has no effect if equal to greater than 1000000
which happens to match HTML_REFERS, but no error was checked.
This caused 100% CPU utiliation constantly following the tail
of the web server access log with default value.
nanosleep(2) has more relaxed limits.
This commit does a like for like replacement and also adds
error checking in case of a similar error in the future.
Signed-off-by: Roy Marples roy@marples.name