Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Design #89

Open
allo- opened this issue Jul 20, 2017 · 6 comments
Open

Improved Design #89

allo- opened this issue Jul 20, 2017 · 6 comments

Comments

@allo-
Copy link
Owner

allo- commented Jul 20, 2017

The website could use some nice design.
Help wanted from people, who know how to create good designs.

@allo- allo- added this to Todo in Firefox Profilemaker Apr 11, 2019
@allo- allo- mentioned this issue Sep 15, 2020
2 tasks
@plungingChode
Copy link
Contributor

plungingChode commented Nov 7, 2020

I tried my best with #214 .

@allo-
Copy link
Owner Author

allo- commented Nov 7, 2020

Thank you for the effort!
I need to take a closer look before saying more about it.

Maybe you can post a screenshot for now so I can get a first impression?

@plungingChode
Copy link
Contributor

plungingChode commented Nov 7, 2020

Sure thing, here it is:
image

It's currently using the default select/text input elements, but I plan to change that to custom ones (as with the checkbox widget).
image

@allo-
Copy link
Owner Author

allo- commented Nov 7, 2020

This is great. The side bar looks very professional.

The checkboxes may be a bit too large (in relation to the text next to them), but this are details.
I am not sure about adding too many custom widgets. The check boxes may have an advantage because most native checkboxes are rather small, but I think for text fields and dropdown menus it's nice to have the native look.

@plungingChode
Copy link
Contributor

plungingChode commented Nov 7, 2020

The checkboxes are implemented, so that they can be resized by changing a single height/width pair in the CSS. And if the other widgets are not necessary, it's all the simpler for me.

@allo-
Copy link
Owner Author

allo- commented Nov 7, 2020

I am not sure and you seem to know about design, so maybe the custom widgets would fit the design.
The details can be tweaked later and I will test it on my own. I just wanted the screenshots for a first impression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Firefox Profilemaker
  
New Settings and Addons
Development

No branches or pull requests

2 participants