Returns all Choice or Questions' versions if requested #25

Merged
merged 1 commit into from Aug 27, 2012

Projects

None yet

2 participants

@vitorbaptista

Hi,

I've added the param version, that can be sent when hitting ChoicesController#show or QuestionsController#show. If it's equal to "all", we include the "versions" association in the response.

There's no way to ask for a specific version, or to revert, but that shouldn't be hard to implement.

What do you think?

Cheers!
Vítor.

@lukebaker
All Our Ideas member

Vitor, do you anticipate needing to request a specific version or to revert? If so, I think I'd prefer to wait until we have those pieces in this pull request so that we are sure the API parameters / calls are cohesive.

@vitorbaptista
@lukebaker
All Our Ideas member

Gotcha, if you don't need it. We can merge this as-is.

@lukebaker lukebaker merged commit f408721 into allourideas:master Aug 27, 2012
@vitorbaptista

Great, Luke! I've just closed the issue #24 and added the new parameter to the API docs. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment