Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Inconsistent types between revm and rpc-types access lists #19

Closed
Evalir opened this issue Nov 5, 2023 · 1 comment
Closed

[Bug] Inconsistent types between revm and rpc-types access lists #19

Evalir opened this issue Nov 5, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@Evalir
Copy link
Contributor

Evalir commented Nov 5, 2023

Component

rpc-types

What version of Alloy are you on?

latest

Operating System

None

Describe the bug

REVM access lists are U256, while we use FixedBytes<32>. We should use the same ones for both. We may have a mild preference for U256 in the JSON rpc request type because the encoding is significantly shorter for common cases
@Evalir Evalir added the bug Something isn't working label Nov 5, 2023
@Evalir
Copy link
Contributor Author

Evalir commented Nov 7, 2023

Fixed with #22

@Evalir Evalir closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Evalir