Thoughts on default side panel bgcolor. #47

Closed
jordwalke opened this Issue Nov 2, 2011 · 5 comments

Projects

None yet

4 participants

@jordwalke

I saw some talk about allowing customization of the side bar. I think it's a great idea, but even if you decide not to allow customization right now, could we make the default similar to other mac application sidebars, which have a subtle grey/blue color?
I notice other apps have a background that is approximately RGB(.86,.88,.91), with a single 1px thin vertical line that separates the side panel from the main content with color approximately RGB(.69, .69, .69) though there's no set rules for this.
I'd really love customizability of the color eventually, as I switch between dark and light schemes, and the bright background color is kind of jaring when I have a dark color scheme - I understand we'd need to allow customization of icons/font colors, triangle arrows etc - so it's understandable there's more important milestones.

@ashgti
ashgti commented Nov 5, 2011

Would it be possible to get the colors from the current theme?

@tobia
tobia commented Dec 16, 2011

I gave the file browser the same look as the Finder and iTunes sidebar.

See pull request.

@jordwalke

I really like this. Vico pulled it off nicely.

@kjyv
Collaborator
kjyv commented Feb 19, 2016

#84 seems related or solves part of this.

@kjyv
Collaborator
kjyv commented Feb 21, 2016

400937e introduces an option to use the current theme colors. The colors of the panel otherwise use [NSColor controlBackgroundColor] which is not the finder panel color (which is not directly defined) but it is the standard color for many list views. Also I think the finder sidebar is a different use cases, finder file trees look white and that color seems to be close or the same.

@kjyv kjyv closed this Feb 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment