-
-
Notifications
You must be signed in to change notification settings - Fork 41
Remove TopSnippets cog and fix pre-commit #826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove TopSnippets cog and fix pre-commit #826
Conversation
… and remove TopSnippets cog
|
Merging to
|
Reviewer's Guide by SourceryThis pull request removes the TopSnippets cog, as its functionality is now covered by the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @electron271 - I've reviewed your changes - here's some feedback:
Overall Comments:
- It's good that you fixed the pre-commit issues, but try to avoid mixing unrelated changes in the same PR in the future.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
ghost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Description
Sorry for having pre-commit in this pr, could not commit the original purpose of this pr without fixing.
TopSnippets is now superseded by $ls which also sorts by uses.
Guidelines
My code follows the style guidelines of this project (formatted with Ruff)
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation if needed
My changes generate no new warnings
I have tested this change
Any dependent changes have been merged and published in downstream modules
I have added all appropriate labels to this PR
I have followed all of these guidelines.
How Has This Been Tested? (if applicable)
Tried running $ts
Screenshots (if applicable)
Please add screenshots to help explain your changes.
Additional Information
Closes #810
Summary by Sourcery
Remove TopSnippets cog and update pre-commit configuration
Build:
Chores: