New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Fields processing in Steps (partially fixes #14) #39

Merged
merged 3 commits into from Apr 7, 2017

Conversation

2 participants
@sskorol
Contributor

sskorol commented Mar 29, 2017

  • added string2field transformation logic to allow extracting values from user types specified within Step annotation;
  • added a test (with dummy objects) for covering the following scenarios: common objects, arrays, collections, null-values, nested fields' inclusion;
  • added jOOR library to avoid reflection-based staff overhead while fields processing;
Sergey Korol
Proposal: fields processing in Steps.
 - added string2field transformation logic to allow extracting values from user types specified within Step annotation;
 - added a test (with dummy objects) for covering the following scenarios: common objects, arrays, collections, null-values, nested fields' inclusion;
 - added jOOR library to avoid reflection-based staff overhead while fields processing;

@baev baev added the work:review label Mar 29, 2017

@just-boris just-boris requested review from baev and removed request for baev Mar 29, 2017

@baev baev requested review from ehborisov and eroshenkoam Apr 4, 2017

@sskorol

This comment has been minimized.

Show comment
Hide comment
@sskorol

sskorol Apr 4, 2017

Contributor

@baev fixed

Contributor

sskorol commented Apr 4, 2017

@baev fixed

@baev baev merged commit 9af83db into allure-framework:master Apr 7, 2017

1 check passed

Jenkins Build finished. No test results found.
Details

@baev baev removed work:review labels Apr 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment