don't assume windows gaming input available for mingw #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In updating dvui to zig version
0.14.0-dev.2628+5b5c60f43, on Windows I encountered the following build error:I don't have MSVC installed, and I guess zig compiling via mingw headers doesn't provide this header.
Therefore to make the build succeed, I had to adjust this predefined macro not to assume the header is present.
Having build.zig options/integration for this would probably be preferable, however,
for whatever reason for
.windowsos tag the pregenerated config is chosen,and I didn't want to touch any of that logic without the necessary context,
so this seemed like the minimal fix.
As far as I understand,
__MINGW32__shouldn't be defined when compiling formsvcABI (which I assume includes the header),so behavior should be the same for that target.