Deps: Temporarily restrict php-cs-fixer 3.65.0 until fix for nullable decalaration is released #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… decalaration is released Php-cs-fixer 3.65.0 (included in ecs 12.4+) contains broken NullableTypeDeclarationFixer, which could lead to syntax error in code. See PHP-CS-Fixer/PHP-CS-Fixer#8330 This should be fixed in next php-cs-fixer release, then we can remove the version restriction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Php-cs-fixer 3.65.0 (included in ecs 12.4+) contains broken
NullableTypeDeclarationFixer,which could lead to syntax error in code. It also cause unit tests to fail.See PHP-CS-Fixer/PHP-CS-Fixer#8330 for the bug
This should be fixed in next php-cs-fixer release (there is already a PR with a fix), then we can remove the version restriction.