Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matt duffy problem #31

Open
almartin82 opened this issue Mar 15, 2016 · 0 comments
Open

matt duffy problem #31

almartin82 opened this issue Mar 15, 2016 · 0 comments
Assignees
Labels
Milestone

Comments

@almartin82
Copy link
Owner

what I thought was an error in the projections for #26 is actually... just how things are going. fangraphs (a reasonably complete but not outlandish projection universe) has 13 name collsions:

table(pos_df$fullname)[table(pos_df$fullname) > 1] %>% sort()

     Carlos Perez    Carlos Sanchez Christian Vazquez  Daniel Robertson 
                2                 2                 2                 2 
    Jesus Montero     Jose Gonzalez     Jose Martinez        Juan Perez 
                2                 2                 2                 2 
       Matt Duffy    Michael Miller    Michael Taylor     Tanner Murphy 
                2                 2                 2                 2 
      Tyler Moore 
                2 

I think our playerid match functions should pre-process these names, and attempt to match on name/team...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant