New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BoxWidget collapse issue when box inside box #1681

Closed
rmgc77 opened this Issue Oct 11, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@rmgc77

rmgc77 commented Oct 11, 2017

When I have a box inside a box, if I colapse the child box, the parent box colapses as well.
I found this issue only after I upgraded from 2.3 to 2.4

In adminlte.js, the BoxWidget toggle method is called twice after clicking the collapse button of the child box. Child box triggers the toogle method for itself and also for parent box.
If you click the parent box collapse button, toggle method is only called once, and only the parent box is toogled.

I can't figure out why. It seams a simple fix if you can find the source of the problem.

@rmgc77 rmgc77 changed the title from When Box inside box to BoxWidget collapse issue when box inside box Oct 12, 2017

@rmgc77

This comment has been minimized.

rmgc77 commented Oct 12, 2017

Example of the issue on fiddle: https://jsfiddle.net/ayeojg9o/4/

rmgc77 added a commit to rmgc77/AdminLTE that referenced this issue Oct 12, 2017

Update adminlte.js
Fix for issue almasaeed2010#1681 (BoxWidget collapse issue when box inside box )
@rmgc77

This comment has been minimized.

rmgc77 commented Oct 12, 2017

I've commited a modification that solves this issue.
Already implemented it in my project and works.

bmanifold added a commit to bmanifold/AdminLTE that referenced this issue Oct 12, 2017

Fix box inside box collapsing error (almasaeed2010#1681)
* Previously, with a .box inside a .box, any clicking on a
  collapse/expand button in either .box would cause both of them to
  collapse/expand.  This commit makes sure parent and child boxes
  do not interfere with each other.

almasaeed2010 added a commit that referenced this issue Oct 26, 2017

Fix box inside box collapsing error (#1681) (#1685)
* Previously, with a .box inside a .box, any clicking on a
  collapse/expand button in either .box would cause both of them to
  collapse/expand.  This commit makes sure parent and child boxes
  do not interfere with each other.
@fatoskurtishi

This comment has been minimized.

fatoskurtishi commented Jun 24, 2018

Still having problems with version 2.4.2 ? any issue ?

@rmgc77

This comment has been minimized.

rmgc77 commented Jun 24, 2018

@interludic

This comment has been minimized.

interludic commented Jul 16, 2018

Still seems to be an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment