Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to bootstrap 3.4 #2038

Closed
QuentinCurtet opened this Issue Dec 17, 2018 · 5 comments

Comments

Projects
None yet
5 participants
@QuentinCurtet
Copy link

QuentinCurtet commented Dec 17, 2018

Issue type:

  • Feature request
  • Bug report
  • Documentation

Environment:

  • AdminLTE Version: 2.4.8
  • Operating System: Debian 9
  • Browser (Version): Chrome (Latest)

Description:

Bootstrap released a new version for 3.x branch. Is it possible to update to this version because, it fixes some XSS breaches.
https://github.com/twbs/bootstrap/releases/tag/v3.4.0
https://github.com/twbs/bootstrap/tree/v3.4.0

@kabutotx

This comment has been minimized.

Copy link

kabutotx commented Jan 30, 2019

I just dropped bootstrap 3.4 js and css in my project and it seems to be working fine.

@Jamesking56

This comment has been minimized.

Copy link

Jamesking56 commented Jan 30, 2019

I think this needs re-categorising as a Bug Report and an increase in priority since the current Bootstrap version used has security vulnerabilities

@almasaeed2010 can we get this upgraded?

@QuentinCurtet

This comment has been minimized.

Copy link
Author

QuentinCurtet commented Feb 18, 2019

Update on this ?
It would be nice to update to 3.4.1, because of one new security breach (XSS) => https://github.com/twbs/bootstrap/releases/tag/v3.4.1

@almasaeed2010

This comment has been minimized.

Copy link
Owner

almasaeed2010 commented Feb 18, 2019

See v2.4.9

Thanks and sorry it took that long!

@tabacitu

This comment has been minimized.

Copy link

tabacitu commented Feb 27, 2019

@almasaeed2010 , I think Packagist no longer auto-updates new releases for this package. I know you needed to re-login to Packagist a few months ago, maybe you didn't do it at the time.

I've tried to install 2.4.9 using composer and it says that the version doesn't exist. From what I can tell:

  • the version exists on Github
  • the version does NOT exist on Packagist

screenshot 2019-02-27 at 18 25 43

I think you have to Login with Github on Packagist, and hit "Update" on the package, so the tag shows up. Can you please try that, so people can get the latest version (with the BS security fix) with composer update?

Thanks for the wonderful work!

@tabacitu tabacitu referenced this issue Feb 27, 2019

Merged

[WIP] Laravel 5.8 support #362

16 of 18 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.