syntax tree display #2563

Closed
gbrault opened this Issue Jan 11, 2017 · 7 comments

Projects

None yet

3 participants

@gbrault
Contributor
gbrault commented Jan 11, 2017

Hi!

thanks a lot for this library!

just to provide a usage case

result is here:

https://github.com/gbrault/railroad-diagrams/blob/gh-pages/live/doc/svg/expression-results.png

And railroad script is used for validation parser generator

https://github.com/gbrault/railroad-diagrams/blob/gh-pages/live/doc/readme.md

I wouldn't have the chance to do this work without vis.js

Thanks again!

Gilbert

@Tooa
Member
Tooa commented Jan 11, 2017

Very Cool! Can we use this for our showcases page? Feel free to create a pull request with the showcase.

@gbrault
Contributor
gbrault commented Jan 11, 2017 edited

I agree of course. How can I manage to do this pull request? Can you guide me?
Thanks

@Tooa
Member
Tooa commented Jan 11, 2017

You need to fork this repository and checkout the develop branch. Then take a look at this pull request for the files you need to provide/change. Once you did commit the changes to your local repository on a separate branch you can use the Github Web-Interface to create the pull request. Make sure your pull-request is to the develop branch. Let me know if you need further help.

@Tooa Tooa added the Docs label Jan 11, 2017
@gbrault
Contributor
gbrault commented Jan 12, 2017

Actually, it seems the showcase are in the gh-pages branch, can you confirm?

@mojoaxel
Member

Actually, it seems the showcase are in the gh-pages branch, can you confirm?

Yes. You'll need to make a pull-request to the gh-pages branch. Please make sure to base it on the current ph-pages branch and not develop. Thx.

@gbrault
Contributor
gbrault commented Jan 12, 2017

I did submit the pull-request! Hope this will work. let me know. You can then close the ticket!

Gilbert

@mojoaxel mojoaxel added a commit that referenced this issue Jan 13, 2017
@gbrault @mojoaxel gbrault + mojoaxel feat: #2563 added RailRoad SRFB showcase (#2571)
* added RailRoad SRFB showcase
* Changed Image; size was imposed
c5cac5c
@mojoaxel
Member

merged with #2571 an 3219c5d

@mojoaxel mojoaxel closed this Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment