New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.21.0 : broken highlight code ? #3589

Open
bthieurmel opened this Issue Oct 18, 2017 · 17 comments

Comments

Projects
None yet
5 participants
@bthieurmel
Copy link

bthieurmel commented Oct 18, 2017

Hi,

It seems that new v4.21.0 breaks neighbourhood Highlight example :

http://visjs.org/examples/network/exampleApplications/neighbourhoodHighlight.html

@wimrijnders

This comment has been minimized.

Copy link
Contributor

wimrijnders commented Oct 18, 2017

Just checked it, working as intended. What are you seeing to conclude that it is broken?

Maybe it's a platform thing. I tested on linux+firefox/chrome and it looks good. What's your OS+browser?

@bthieurmel

This comment has been minimized.

Copy link
Author

bthieurmel commented Oct 18, 2017

Nodes and edges don't became greyed on click. Without any message in web console.

windows + google chrome

@wimrijnders

This comment has been minimized.

Copy link
Contributor

wimrijnders commented Oct 18, 2017

Ah, a color thing. I'm the worst possible guy to examine it, then 😄.

Yes, it does say that in the description. But I see it's working because the edges in question turn bold.

Okay, I'll have a look. Maybe the description needs to be changed instead (whatever it takes to make it consistent).

@wimrijnders wimrijnders added Problem and removed Question labels Oct 18, 2017

@bthieurmel

This comment has been minimized.

Copy link
Author

bthieurmel commented Oct 18, 2017

Thanks.

I'm the developper of a R package visNetwork based on the great library vis.js.

And I've some special options based on this kind of functionnality (change colors of subset of nodes / edges on click), and so all are broken with the current 4.21.0...!

(If you want to have a look : http://datastorm-open.github.io/visNetwork/options.html)

@wimrijnders

This comment has been minimized.

Copy link
Contributor

wimrijnders commented Oct 18, 2017

Ah, R, rings a bell. We've interacted via issues before.

I followed the link (and the page is a candidate for showcasing IMHO), but it doesn't help much. Would it be possible to isolate the relevant options in an example?

@bthieurmel

This comment has been minimized.

Copy link
Author

bthieurmel commented Oct 18, 2017

Yes, I redirected some issue send on visNetwork to vis.js....

The link was just for informations, not to help for this issue....(and the site is still under 4.20). So, I think the neighbourhood Highlight example is a good case to try to fix that ?

http://visjs.org/examples/network/exampleApplications/neighbourhoodHighlight.html

@wimrijnders

This comment has been minimized.

Copy link
Contributor

wimrijnders commented Oct 18, 2017

OK, on my TODO. Don't want to do it right now due to tax people becoming increasingly agitated at me, on the grounds of me not having my paperwork done.

@bthieurmel

This comment has been minimized.

Copy link
Author

bthieurmel commented Oct 18, 2017

First observation : seems to be broken if node have a group value.

Update : I think it's a more globally problem :

  • before : individual nodes parameters > group options > global nodes
  • now : group options > individual nodes parameters
@wimrijnders

This comment has been minimized.

Copy link
Contributor

wimrijnders commented Oct 19, 2017

I'm ashamed to say that it took me a while to understand the issue; the highlight is set properly, but in previous versions all the other nodes and edges were grayed out. And that is not happening in latest release.

What is happening now, is that the groups override the color values, so the gray color never appears. I will have to treat the colors in the same way as the fonts are treated, where the order is now strictly forced.

I guess this means that this issue is confirmed.


I wouldn't call this 'broken' though, it's a case of by fixing one bug, another bug is uncovered (but I fully realize this depends on one's point of view!). I will actually have to scan all options to see if any of the other ones will have this issue as well. I'll do that in a separate PR; my goal is to get this in the bugfix release next week.

@wimrijnders wimrijnders added Confirmed Bug and removed Problem labels Oct 19, 2017

@bthieurmel

This comment has been minimized.

Copy link
Author

bthieurmel commented Oct 19, 2017

Not only a color problem, but the issue is for all parameters set in groups and in nodes. (The highlight example see the bug for label too)

@wimrijnders

This comment has been minimized.

Copy link
Contributor

wimrijnders commented Oct 19, 2017

Except for fonts! I can vouch for that. I fixed that particular issue: #3486. Easily the toughest thing I had to fix within Network. I guess you can view this as fallout.

@bthieurmel

This comment has been minimized.

Copy link
Author

bthieurmel commented Oct 19, 2017

vis.js documentation confirme that individual nodes parameters must be prioritary to group options:

Node specific styling overrides group styling.

@wimrijnders

This comment has been minimized.

Copy link
Contributor

wimrijnders commented Oct 19, 2017

And that's how it should be. I'm not disputing that.

This just confirms for me that the options handling is broken.

@bthieurmel

This comment has been minimized.

Copy link
Author

bthieurmel commented Oct 19, 2017

Thanks for quick answers, Good luck and thank you for your work...!

@wimrijnders

This comment has been minimized.

Copy link
Contributor

wimrijnders commented Oct 19, 2017

OK. I personally guarantee that this will get into the bugfix release (planned weekend of 28 nov). For me, this is a matter of having enough coffee. If this issue is hindering you, I think the best thing is to go back to the previous version for the time being.

@mojoaxel mojoaxel added this to the Patch Release v4.21.1 milestone Oct 19, 2017

@david-bc

This comment has been minimized.

Copy link

david-bc commented Oct 19, 2017

Confirmed.

Falling back to npm i -S vis@4.20.1 --save-exact solves the group/color issue

@shaildegoam

This comment has been minimized.

Copy link

shaildegoam commented Jun 13, 2018

It still does not work :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment