Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Ignore image/content values when generating Production MD #35

Closed
jlarmstrong opened this issue May 24, 2022 · 2 comments · Fixed by #40
Closed

[FEATURE] Ignore image/content values when generating Production MD #35

jlarmstrong opened this issue May 24, 2022 · 2 comments · Fixed by #40
Assignees
Labels
enhancement New feature or request ready to ship Feature is ready to be included in new version work started Work on this feature has started

Comments

@jlarmstrong
Copy link

Is your feature request related to a problem? Please describe.
When generating the Production MD file image attributes create duplicate strings for the table print out for the column headers. This causes the production combined MD file to grow exponentially in size. Ideally some of these values in the output would be truncated or flagged to be ignored.

Describe the solution you'd like
Provide a method to blacklist specific fields for the production build; or consolidate the output in the tables to simply fill in some pre-defined "field-to-large" or other replacement.

Additional context
Fields that are subject to bloating the final production output include but are limited to:

  • wallpaperImage
  • payload
  • scriptContent
@jlarmstrong jlarmstrong added the enhancement New feature or request label May 24, 2022
@almenscorner almenscorner added the under consideration Feature request is under consideration label May 27, 2022
@almenscorner
Copy link
Owner

Thank you for the input Jared, I will take a look at how this could be implemented as soon as I have some down time :)

@almenscorner
Copy link
Owner

I have a new version up on testpypi that includes a new parameter while running the documentation that lets you configure the max length you want to display. Test this version by installing it using,

pip install -i https://test.pypi.org/simple/ IntuneCD-beta

You can then run documentation and set the max length like this,

intunecdbeta-startdocumentation -p /your/path -o your/path/doc.md -m {your_int_value}

Any field that are longer than your specified value will display "Value too long to display".

@almenscorner almenscorner added will include Feature will be included work started Work on this feature has started and removed under consideration Feature request is under consideration labels Jun 5, 2022
@almenscorner almenscorner added ready to ship Feature is ready to be included in new version and removed will include Feature will be included labels Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready to ship Feature is ready to be included in new version work started Work on this feature has started
Projects
Status: Shipped
Development

Successfully merging a pull request may close this issue.

2 participants