This repository has been archived by the owner on Mar 11, 2021. It is now read-only.
Record work item comments revisions (#914) #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a `comment_revisions` table to retain all changes on comments, along with a timestamp, the Id of the author identity and the type of operation that was performed. When the comment is deleted, the 'body' and 'markup' fields are 'Nil'. The list of revisions is retrieved in its historical order. Also renamed the `workitem.WorkItemRevision` to `workitem.Revision` and removed the `WorkItem` part in the revision constants. Fixes fabric8-services#914 Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
aslakknutsen
suggested changes
Mar 3, 2017
comment/comment_revision.go
Outdated
| // RevisionTypeDelete a work item deletion | ||
| RevisionTypeDelete // 2 | ||
| _ // ignore 3rd value | ||
| // RevisionTypeUpdate a work item update |
workitem/workitem_revision.go
Outdated
| @@ -6,22 +6,22 @@ import ( | |||
| uuid "github.com/satori/go.uuid" | |||
| ) | |||
|
|
|||
| // RevisionType defines the type of revision for a work item | |||
| // WorkIteRevisionTypemRevisionType defines the type of revision for a work item | |||
Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #930 +/- ##
==========================================
+ Coverage 68.59% 68.63% +0.04%
==========================================
Files 91 93 +2
Lines 6916 6957 +41
==========================================
+ Hits 4744 4775 +31
- Misses 1730 1735 +5
- Partials 442 447 +5
Continue to review full report at Codecov.
|
sbose78
reviewed
Mar 3, 2017
| assert.Equal(s.T(), rendering.SystemMarkupMarkdown, *revision1.CommentMarkup) | ||
| assert.Equal(s.T(), s.testIdentity1.ID, revision1.ModifierIdentity) | ||
| // revision 2 | ||
| revision2 := commentRevisions[1] |
There was a problem hiding this comment.
I'm torn between
Whether we should move repetitive code inside a different method ,
and
the prospect of losing line numbers in case of error.
:)
There was a problem hiding this comment.
let me see what I can about it
There was a problem hiding this comment.
actually, code would look like this:
expectedBody := "Body"
expectedMarkup := rendering.SystemMarkupMarkdown
expectedRevision := comment.Revision{
CommentID: c.ID,
ModifierIdentity: s.testIdentity1.ID,
Type: comment.RevisionTypeCreate,
CommentBody: &expectedBody,
CommentMarkup: &expectedMarkup,
}
s.assertRevision(revision1, expectedRevision)
along with
func (s *revisionRepositoryBlackBoxTest) assertRevision(expected, actual comment.Revision) {
assert.Equal(s.T(), expected.ID, actual.CommentID)
assert.Equal(s.T(), expected.Type, actual.Type)
assert.Equal(s.T(), expected.ModifierIdentity, actual.ModifierIdentity)
assert.Equal(s.T(), expected.CommentBody, *actual.CommentBody)
assert.Equal(s.T(), expected.CommentMarkup, *actual.CommentMarkup)
}
so there's no real benefit in terms of readability and number of lines, and indeed, in case of assertion error, we would not know which revision is wrong..
| } | ||
|
|
||
| func (s *revisionRepositoryBlackBoxTest) TearDownTest() { | ||
| //s.clean() |
There was a problem hiding this comment.
ha yes, good point. I removed it during my last tests to verify the state of the data in the DB. Let me remove the comment.
aslakknutsen
approved these changes
Mar 3, 2017
Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
AdamJ
pushed a commit
to AdamJ/almighty-core
that referenced
this pull request
Mar 7, 2017
…ervices#930) * Record work item comments revisions (fabric8-services#914) Added a `comment_revisions` table to retain all changes on comments, along with a timestamp, the Id of the author identity and the type of operation that was performed. When the comment is deleted, the 'body' and 'markup' fields are 'Nil'. The list of revisions is retrieved in its historical order. Also renamed the `workitem.WorkItemRevision` to `workitem.Revision` and removed the `WorkItem` part in the revision constants. Fixes fabric8-services#914 Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
comment_revisionstable to retain all changes on comments,along with a timestamp, the Id of the author identity and the type
of operation that was performed.
When the comment is deleted, the 'body' and 'markup' fields are 'Nil'.
The list of revisions is retrieved in its historical order.
Also renamed the
workitem.WorkItemRevisiontoworkitem.Revisionand removed the
WorkItempart in the revision constants.Fixes #914
Signed-off-by: Xavier Coulon xcoulon@redhat.com