Support for DBConnection #3
Comments
Any progress on Ecto 2.0 support? Now that Phoenix 1.2 is out and requires Ecto 2.0 by default. |
I have been working on Ecto 2 support for some time now. Currently, here what has been done so far:
I'm working on failing integration tests (only Currently, you should be able to work with basic DB queries (changesets, I have swapped
def deps do
[{:rethinkdb_ecto, github: "almightycouch/rethinkdb_ecto"}]
end |
Is your fork ready for a discussion of merging into the mainline? |
Hi @hamiltop, The fork is ready to be merged without conflics. All the tests are passing successfully with the exception of 5 tests in There are a few implementation details that should be discussed thought:
|
Ecto 2.0 requires adapters to support
DBConnection
(https://github.com/elixir-lang/ecto/issues/1215). The support forDBConnection
has already been implemented quiet well in my fork of theRethinkDB
driver.Still, some features are missing (SSL support) and i some tests (
connection_test.exs
) have to be adjusted/rewritten. I will also talk with @hamiltop to see if he agrees to make the change (I think having support for different pool libraries in the driver could be a good thing).The text was updated successfully, but these errors were encountered: