New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop to use `events` #352

Closed
azu opened this Issue Jun 9, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@azu
Member

azu commented Jun 9, 2018

I've tried to drop event #349 for reducing file size.

refactor(almin): use Dispatcher insteadof events #349

But, some problem is found.

  • Almin codebase use emit and dispatach quite differently
    • Example Store

We want to investigate about it.

Pros

  • Reduce file size
  • Perf?
  • React Native compatible
    • React Native bundler does not includes events by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment