fixes flow type-def can not be read. #108

Merged
merged 1 commit into from Feb 26, 2017

Conversation

Projects
None yet
2 participants
@k-kinzal
Contributor

k-kinzal commented Feb 26, 2017

todomvc-flow is not read flow type-def from almin.

// @flow
"use strict";
import {UseCase} from 'almin';
UseCase.hogehoge; // UseCase is `unkown`
$ flow type-at-pos sample.js 4 1
(unknown)
/path/to/almin/example/todomvc-flow/sample.js:4:1,4:7

See the following locations:
/path/to/almin/example/todomvc-flow/sample.js:4:1-7:
any

https://flowtype.org/docs/declarations.html#declaration-files
".js.flow” style. is better when distributing type-def.

@azu

This comment has been minimized.

Show comment
Hide comment
@azu

azu Feb 26, 2017

Member

@k-kinzal Good catch! Thanks.

Member

azu commented Feb 26, 2017

@k-kinzal Good catch! Thanks.

@azu azu merged commit ef25956 into almin:master Feb 26, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@azu

This comment has been minimized.

Show comment
Hide comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment