New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for displaying images from a file or from a URL #258

Merged
merged 1 commit into from Nov 5, 2018

Conversation

Projects
None yet
2 participants
@sbrunk
Contributor

sbrunk commented Nov 3, 2018

Extends on #255 to allow displaying images from local files or URLs (embedded or linked).

Example usage:

val url = "https://scala-lang.org/resources/img/frontpage/scala-spiral.png"
Image.fromUrl(url, width=Some("100px"), embed=true)

I think there's still potential to make this more generic in the future. Perhaps even a type class based approach that allows users to encode objects into the different mime types supported by the frontend.

@alexarchambault

This comment has been minimized.

Member

alexarchambault commented Nov 5, 2018

Thanks @sbrunk!

@alexarchambault alexarchambault merged commit eed7aa2 into almond-sh:master Nov 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sbrunk sbrunk deleted the sbrunk:image-support branch Nov 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment